Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set Dimensions per Metric #27

Closed
austince opened this issue Oct 8, 2019 · 3 comments · Fixed by #28
Closed

Ability to set Dimensions per Metric #27

austince opened this issue Oct 8, 2019 · 3 comments · Fixed by #28

Comments

@austince
Copy link
Contributor

austince commented Oct 8, 2019

Hey there, would anyone be interested in a PR that allows you to set the dimensions on a per-metric, or perhaps per-metric-glob, basis? We're running into the issue of the 10 metric limit truncating the actual dimensions we care about.

I'm thinking about updating the Bridge and passing in a flag like:

	dimensionsForMetrics     = flag.String("dimensions_for_metrics", os.Getenv("DIMENSIONS_FOR_METRICS"), "Hard-coded dimensions for metrics (semi-colon-separated list of comma-separated dimensions, e.g. 'flink_jobmanager=job,host;zk_up=host,pod;')")

// ...

type Bridge struct {
	dimensionsForMetricMap        map[string][]string
        // or
	dimensionsForMetrics        []glob.Glob[]string
}

Or even the ability to set the max # of dimensions per metric might solve our use case.

@aknysh
Copy link
Member

aknysh commented Oct 8, 2019

@austince PRs are very welcome, thanks

@austince
Copy link
Contributor Author

austince commented Oct 8, 2019

@aknysh any suggestions on the feature / approach?

@austince
Copy link
Contributor Author

austince commented Oct 8, 2019

Also, has there been any discussion for moving to go modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants