Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump AWS provider and update examples to include ECS Service Connect config #238

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Bump AWS provider and update examples to include ECS Service Connect config #238

wants to merge 7 commits into from

Conversation

joe-niland
Copy link
Member

what

  • Update examples/complete to include ECS Service Connect config
  • bump AWS provider version to support latest ECS Service Connect config

why

  • Fix issue when using older AWS provider
  • Increase test coverage

references

@joe-niland
Update examples/complete to include ECS Service Connect config
dda6408 
- bump AWS provider version to support latest ECS Service Connect config
@joe-niland
Update docs
063c116
@joe-niland joe-niland requested review from a team as code owners May 17, 2024 01:19
@mergify mergify bot added the triage Needs triage label May 17, 2024
@joe-niland
Copy link
Member Author

/terratest

@joe-niland joe-niland added the patch A minor, backward compatible change label May 17, 2024
@joe-niland joe-niland changed the title Update examples/complete to include ECS Service Connect config Bump AWS provider and update examples to include ECS Service Connect config May 17, 2024
@joe-niland
Copy link
Member Author

/terratest

@joe-niland
Copy link
Member Author

/terratest

joe-niland
joe-niland commented May 17, 2024
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
jamengual
jamengual previously approved these changes May 17, 2024
View reviewed changes
@mergify mergify bot removed the triage Needs triage label May 17, 2024
@joe-niland
Copy link
Member Author

/terratest

@mergify Mergify
Copy link

mergify bot commented Aug 15, 2024

💥 This pull request now has conflicts. Could you fix it @joe-niland? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Aug 15, 2024
@mergify mergify bot closed this Aug 15, 2024
@mergify Mergify
Copy link

mergify bot commented Aug 15, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed the conflict This PR has conflicts label Aug 15, 2024
@joe-niland joe-niland reopened this Aug 16, 2024
@mergify Mergify
Copy link

mergify bot commented Aug 16, 2024

💥 This pull request now has conflicts. Could you fix it @joe-niland? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Aug 16, 2024
@mergify mergify bot removed the conflict This PR has conflicts label Aug 16, 2024
@joe-niland
Copy link
Member Author

/terratest

@joe-niland
Copy link
Member Author

joe-niland commented Aug 16, 2024 •
edited
Loading

Hi @jamengual I fixed merge conflicts - would you mind reviewing again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual left review comments

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
2 participants
@joe-niland @jamengual