This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Improve IAM Report Error Handling #1009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
changed the title
fix: Improve Error Handling
fix: Improve IAM Report Error Handling
Jun 6, 2022
erezrokah
approved these changes
Jun 7, 2022
bbernays
commented
Jun 7, 2022
amanenk
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
disq
reviewed
Jun 8, 2022
disq
approved these changes
Jun 9, 2022
yevgenypats
approved these changes
Jun 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thank you for making CloudQuery awesome by submitting a PR π
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code πgolangci-lint run
π¨ (install golangci-lint here)go run ./docs/docs.go
and committing the changes π