Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Improve IAM Report Error Handling #1009

Merged
merged 15 commits into from
Jun 9, 2022
Merged

fix: Improve IAM Report Error Handling #1009

merged 15 commits into from
Jun 9, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jun 6, 2022

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner June 6, 2022 20:16
@bbernays bbernays requested review from spangenberg and removed request for a team June 6, 2022 20:16
@bbernays bbernays linked an issue Jun 6, 2022 that may be closed by this pull request
Iam users GenerateCredentialReport has paralel reports capacity that is not accounted #1001
Closed
@bbernays bbernays changed the title fix: Retry Credential Report fix: Improve Error Handling Jun 6, 2022
@bbernays bbernays changed the title fix: Improve Error Handling fix: Improve IAM Report Error Handling Jun 6, 2022
@bbernays bbernays requested review from roneli and amanenk June 7, 2022 14:53
amanenk
amanenk approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbernays bbernays requested a review from disq June 9, 2022 10:35
@bbernays bbernays merged commit 1c77a63 into cloudquery:main Jun 9, 2022
@bbernays bbernays deleted the credential-retry branch June 9, 2022 11:04
@cq-bot cq-bot mentioned this pull request Jun 9, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@disq disq disq approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

@amanenk amanenk amanenk approved these changes

@erezrokah erezrokah erezrokah approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg spangenberg is a code owner automatically assigned from cloudquery/cloudquery-opensource

@roneli roneli Awaiting requested review from roneli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iam users GenerateCredentialReport has paralel reports capacity that is not accounted
5 participants
@bbernays @disq @yevgenypats @amanenk @erezrokah