Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Partial lambda Function Fetch #1194

Merged
merged 10 commits into from
Jul 11, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jul 8, 2022

Summary

Here is an experimental change, where we can populate some data for Lambda Functions as long as the user has access to lambda:List*

Pros:

  • As long as user has access to List they can get some data in the table, they will miss information types.FunctionCodeLocation, types.Concurrency and Tags

Cons:

  • Includes information about function that could have been deleted
  • Continues to try to get details as we cannot be sure if a user doesn't have access to get a specific function or all functions

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner July 8, 2022 15:12
@bbernays bbernays requested review from spangenberg, roneli, disq, hermanschaaf, irmatov, shimonp21 and yevgenypats and removed request for a team July 8, 2022 15:12
@bbernays bbernays linked an issue Jul 8, 2022 that may be closed by this pull request
client/helpers.go Outdated Show resolved Hide resolved
client/helpers.go Outdated Show resolved Hide resolved
client/helpers.go Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit f757824 into cloudquery:main Jul 11, 2022
@bbernays bbernays deleted the partial-lambda-function branch January 5, 2023 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda table not been populated when using ViewOnlyAccess
4 participants