Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Adjust some PKs #849

Merged
merged 2 commits into from
May 11, 2022
Merged

fix: Adjust some PKs #849

merged 2 commits into from
May 11, 2022

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented May 5, 2022

  • drop PK from aws_ssm_compliance_items
  • use ARN as PK in aws_rds_instances

@github-actions github-actions bot added the fix label May 5, 2022
@irmatov irmatov self-assigned this May 5, 2022
@irmatov irmatov marked this pull request as ready for review May 6, 2022 07:12
@irmatov irmatov requested a review from a team as a code owner May 6, 2022 07:12
@irmatov irmatov requested review from yevgenypats, bbernays, spangenberg and a team and removed request for a team and yevgenypats May 6, 2022 07:12
roneli
roneli approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit on migrations

resources/provider/migrations/postgres/30_v0.11.4.down.sql Outdated Show resolved Hide resolved
@irmatov
fix: PK adjustments
b701bbd
@irmatov
fix: Adjust some PKs
9ff8d97 
* drop PK from aws_ssm_compliance_items
* use ARN as PK in aws_rds_instances
@irmatov irmatov merged commit 45807e8 into cloudquery:main May 11, 2022
@irmatov irmatov deleted the fix/some_pks branch May 11, 2022 08:00
This was referenced May 11, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

@roneli roneli roneli approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@irmatov irmatov

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irmatov @bbernays @roneli