This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Fail on errors during initial setup #906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
May 16, 2022
erezrokah
commented
May 16, 2022
erezrokah
changed the title
fix: Classify credentials failures as user errors
fix: Classify credentials failures as user errors during initial setup
May 16, 2022
erezrokah
force-pushed
the
fix/assume_role_errors
branch
from
May 16, 2022 19:29
9ec83f0
to
ca7164d
Compare
erezrokah
commented
May 16, 2022
erezrokah
force-pushed
the
fix/assume_role_errors
branch
from
May 17, 2022 08:21
ca7164d
to
4480ad9
Compare
erezrokah
changed the title
fix: Classify credentials failures as user errors during initial setup
fix: Fail on access errors during initial setup
May 17, 2022
erezrokah
changed the title
fix: Fail on access errors during initial setup
fix: Fail on errors during initial setup
May 17, 2022
erezrokah
commented
May 17, 2022
disq
approved these changes
May 17, 2022
erezrokah
force-pushed
the
fix/assume_role_errors
branch
from
May 17, 2022 08:42
4480ad9
to
36e075a
Compare
roneli
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
erezrokah
added a commit
to erezrokah/cq-provider-aws
that referenced
this pull request
May 31, 2022
β¦ery#906)" This reverts commit c512535.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thank you for making CloudQuery awesome by submitting a PR π
Summary
Fixes #869
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code πgo run ./docs/docs.go
and committing the changes π