Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Fail on errors during initial setup #906

Merged
merged 1 commit into from
May 17, 2022
Merged

fix: Fail on errors during initial setup #906

merged 1 commit into from
May 17, 2022

Conversation

erezrokah
Copy link
Member

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Fixes #869

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah requested a review from a team as a code owner May 16, 2022 17:14
@erezrokah erezrokah requested review from yevgenypats and removed request for a team May 16, 2022 17:14
erezrokah
erezrokah commented May 16, 2022
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
erezrokah
erezrokah commented May 16, 2022
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
@erezrokah erezrokah changed the title fix: Classify credentials failures as user errors fix: Classify credentials failures as user errors during initial setup May 16, 2022
@erezrokah erezrokah marked this pull request as draft May 16, 2022 17:47
@erezrokah erezrokah marked this pull request as ready for review May 16, 2022 19:30
erezrokah
erezrokah commented May 16, 2022
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
@erezrokah erezrokah changed the title fix: Classify credentials failures as user errors during initial setup fix: Fail on access errors during initial setup May 17, 2022
@erezrokah erezrokah changed the title fix: Fail on access errors during initial setup fix: Fail on errors during initial setup May 17, 2022
erezrokah
erezrokah commented May 17, 2022
View reviewed changes
client/errors.go Outdated Show resolved Hide resolved
@erezrokah erezrokah requested review from roneli and removed request for yevgenypats May 17, 2022 08:42
roneli
roneli approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erezrokah erezrokah merged commit c512535 into cloudquery:main May 17, 2022
@cq-bot cq-bot mentioned this pull request May 17, 2022
Merged
@erezrokah erezrokah deleted the fix/assume_role_errors branch May 17, 2022 10:17
erezrokah added a commit to erezrokah/cq-provider-aws that referenced this pull request May 31, 2022
@erezrokah
fix: Revert "fix: Fail on access errors during initial setup (cloudqu…
ec8ff95 
…ery#906)"

This reverts commit c512535.
This was referenced May 31, 2022
Closed
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@disq disq disq approved these changes

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission error is not showing up in console log
3 participants
@erezrokah @disq @roneli