Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Fix NotFound error in aws_sqs_queues #910

Merged
merged 1 commit into from
May 17, 2022
Merged

fix: Fix NotFound error in aws_sqs_queues #910

merged 1 commit into from
May 17, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented May 17, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

The PR fixes not ignored NotFound error in aws_sqs_queues

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run --new-from-rev main 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review May 17, 2022 12:09
@amanenk amanenk requested a review from a team as a code owner May 17, 2022 12:09
@amanenk amanenk requested review from shimonp21 and removed request for a team May 17, 2022 12:09
@roneli roneli merged commit 3c893df into cloudquery:main May 17, 2022
@cq-bot cq-bot mentioned this pull request May 17, 2022
Merged
@amanenk amanenk deleted the fix_not_found_error branch May 31, 2022 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@shimonp21 shimonp21 Awaiting requested review from shimonp21 shimonp21 is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanenk @roneli