This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
feat: Implement Diagnostics.BySeverity filtering #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
May 25, 2022
| @@ -152,6 +152,24 @@ func (diags Diagnostics) CountBySeverity(sev Severity, includeSquashed bool) uin | |||
| return count | |||
| } | |||
|
|
|||
| // BySeverity returns a subset of diagnostics matching the given severity. | |||
| func (diags Diagnostics) BySeverity(sevs ...Severity) Diagnostics { | |||
There was a problem hiding this comment.
Nice 🚀
I actually started something like:
func (diags Diagnostics) Filter(filterFunc func(d Diagnostic) bool) Diagnostics {
res := make(Diagnostics, 0, len(diags))
for _, d := range diags {
if filterFunc(d) {
res = append(res, d)
}
}
return res
}But that could be too generic
There was a problem hiding this comment.
Thought about that, maybe generics can solve it later :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
Adds helper method to filter
diag.Diagnosticsby multiple severity levels.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run --new-from-rev main🚨 (install golangci-lint here)