This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
fix: Respect Multiplexer No Clients #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
amanenk,
roneli and
shimonp21
and removed request for
a team
shimonp21
suggested changes
Jun 4, 2022
shimonp21
approved these changes
Jun 6, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
🤖 I have created a release *beep* *boop* --- ## [0.10.8](v0.10.7...v0.10.8) (2022-06-07) ### Bug Fixes * Respect Multiplexer No Clients ([#313](#313)) ([c873426](c873426)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
This change will have a few side effect that if a user specifies a resource that is not found in the multiplexer then the resource will not be fetched and will not have any indication about why it wasn't fetched
Once this method is approved I will change the test that is blocking the status
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)