Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Init logger, add initial MemDB plugin #70

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Conversation

erezrokah
Copy link
Member

Beginning of #5.

Started implementing a MemDB plugin, but other things got in the way:

  1. Dropped the plugin builder as it makes it harder to extend it (I found https://projectlombok.org/features/experimental/SuperBuilder but didn't dig deeper)
  2. Looks like we shouldn't throw in the serve command so the caller can use the return value and do System.exit(exitCode)
  3. Removed the docs command as now the CLI does it
  4. Initialized the logger via code using log4j2 (couldn't find an easier way to support JSON logging)

Copy link
Collaborator

@mnorbury mnorbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Aug 18, 2023
@mnorbury
Copy link
Collaborator

  1. Dropped the plugin builder as it makes it harder to extend it (I found https://projectlombok.org/features/experimental/SuperBuilder but didn't dig deeper)

Good call with the Plugin builder. I think that class makes more sense as an abstract class.

@kodiakhq kodiakhq bot merged commit 20ebb42 into main Aug 18, 2023
4 checks passed
@kodiakhq kodiakhq bot deleted the feat/init_logger branch August 18, 2023 15:33
kodiakhq bot pushed a commit that referenced this pull request Aug 24, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.1 (2023-08-24)


### Features

* `io.cloudquery.scalar.Binary` implementation ([#20](#20)) ([b9b73d1](b9b73d1))
* `io.cloudquery.scalar.Bool` ([#27](#27)) ([2a91c92](2a91c92)), closes [#26](#26)
* adding basic support for tables ([#19](#19)) ([22b2350](22b2350))
* adding JSON scalar ([#82](#82)) ([fc92542](fc92542)), closes [#63](#63)
* adding Table filterDFS functionaility ([#21](#21)) ([02d8515](02d8515))
* Date scalars ([#36](#36)) ([adc6ba2](adc6ba2)), closes [#34](#34)
* Duration scalar ([#42](#42)) ([7529438](7529438)), closes [#39](#39)
* Encode resources with data ([#88](#88)) ([2c7060f](2c7060f))
* Generics in scalars ([#56](#56)) ([bc7d6e3](bc7d6e3))
* Implement `getTables` ([#71](#71)) ([085c51f](085c51f))
* Implement concurrency and relations resolving ([#91](#91)) ([0a470b7](0a470b7))
* Init logger, add initial MemDB plugin ([#70](#70)) ([20ebb42](20ebb42))
* int/uint/float/string scalars ([#59](#59)) ([39ec6e6](39ec6e6)), closes [#53](#53) [#54](#54) [#58](#58) [#60](#60)
* Resolve CQId, add CQIds to MemDB plugin ([#95](#95)) ([9d7f1bd](9d7f1bd))
* Scalar Timestamp ([#46](#46)) ([4220e92](4220e92)), closes [#44](#44)
* **sync:** Initial insert message support ([#81](#81)) ([bd729bb](bd729bb))
* **sync:** Send migrate messages ([#79](#79)) ([dd2c1a5](dd2c1a5))


### Bug Fixes

* Add `jackson-annotations` to `build.gradle` ([#83](#83)) ([ead7dd9](ead7dd9))
* **deps:** Update dependency com.google.guava:guava to v32 ([#15](#15)) ([ce8028b](ce8028b))
* **deps:** Update dependency io.grpc:grpc-protobuf to v1.57.1 ([#10](#10)) ([bcfa29c](bcfa29c))
* **deps:** Update dependency io.grpc:grpc-services to v1.57.1 ([#11](#11)) ([71c2ea1](71c2ea1))
* **deps:** Update dependency io.grpc:grpc-stub to v1.57.1 ([#12](#12)) ([c65e5d6](c65e5d6))
* **deps:** Update dependency io.grpc:grpc-testing to v1.57.1 ([#13](#13)) ([a7b1fa6](a7b1fa6))
* **deps:** Update plugin org.gradle.toolchains.foojay-resolver-convention to v0.6.0 ([#14](#14)) ([443990c](443990c))
* Flatten tables in getTables gRPC call ([#80](#80)) ([8c9872a](8c9872a))
* Pass options to tables method ([#78](#78)) ([4b77a2f](4b77a2f))


### Miscellaneous Chores

* Release 0.0.1 ([e169dbc](e169dbc))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to automerge PRs once requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants