Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Transaction options via Browser #25

Merged
merged 5 commits into from
Jun 13, 2015
Merged

Expose Transaction options via Browser #25

merged 5 commits into from
Jun 13, 2015

Conversation

clue
Copy link
Owner

@clue clue commented Mar 6, 2015

Closes #15

@clue clue mentioned this pull request Mar 6, 2015
Closed
@asm89
Copy link
Contributor

asm89 commented Mar 6, 2015

@clue LGTM 👍

API wise it could be nice to extract a configuration object instead of doing the array and property exist stuff?

@clue clue added this to the v0.3.0 milestone Mar 9, 2015
@clue
Copy link
Owner Author

clue commented Mar 16, 2015

API wise it could be nice […]

Thanks for your feedback! 👍 I wholeheartedly agree, this API is anything but nice :)

Despite this, this library is considered beta and I'd love to get this feature out. IMO this PR implements a feature that is long overdue. Perhaps we should postpone the API discussion and move this to a dedicated tick?

@asm89
Copy link
Contributor

asm89 commented Mar 17, 2015

@clue Sounds good. Ship this and shape up the API later. I'd just recommend doing that before the first stable. 👍

clue added a commit that referenced this pull request Jun 13, 2015
@clue
Merge pull request #25 from clue-labs/options
c0535ea 
Expose Transaction options via Browser
@clue clue merged commit c0535ea into clue:master Jun 13, 2015
@clue clue deleted the options branch June 13, 2015 19:12
@clue
Copy link
Owner Author

clue commented Jun 13, 2015

@clue Sounds good. Ship this and shape up the API later. I'd just recommend doing that before the first stable. 👍

I agree, please feel free to file a new ticket if you happen to have an idea for a better API and I'd love to get this in 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Expose transaction settings to outside
2 participants
@clue @asm89