Streaming API #31
Streaming API #31
Conversation
|
👍 API looks a little bit clunky, but it seems like the best way given the promise API. |
| @@ -122,6 +122,8 @@ public function send(Request $request) | |||
| )); | |||
| } | |||
| }); | |||
|
|
|||
| $deferred->progress(array('responseStream' => $response, 'requestStream' => $requestStream)); | |||
There was a problem hiding this comment.
nit: have constants defined on Sender instead of these strings? (Part of public API.)
I'm not even going to argue on this :-) Thanks for your feedback, much appreciated! I'd like to get this in rather sooner than later (because other libs depend on this feature). I'm not a fan of the API, hence the statement in the README. I'm looking forward to introduce a breaking change as soon as we figure out a better API 👍 |
|
For the reference: This API is subject to change because it takes advantage of the dreaded promise progress API (reactphp/promise#32). The fetch standard API (#30) might be a good alternative. |
First draft. API is subject to change in future versions.
Closes #26.