Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing array of options with dedicated methods #154

Closed
clue opened this issue Mar 1, 2020 · 2 comments · Fixed by #172
Closed

Consider replacing array of options with dedicated methods #154

clue opened this issue Mar 1, 2020 · 2 comments · Fixed by #172

Comments

@clue
Copy link
Owner

clue commented Mar 1, 2020

For instance:

// old
$browser->withOptions(array('timeout' => 10))->post(…);

// new
$browser->withTimeout(10)->post(…);

This can be added in a 2.x release by deprecating the withOptions() method and still using this method under the hood. In a 3.0 release this method could be removed altogether.

Any input is welcome 👍

@WyriHaximus
Copy link
Contributor

I'll pick this up a create a PR

@WyriHaximus
Copy link
Contributor

PR is up at #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants