Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerLogs API endpoint #12

Closed
clue opened this issue Jun 17, 2015 · 4 comments · Fixed by #53
Closed

Add containerLogs API endpoint #12

clue opened this issue Jun 17, 2015 · 4 comments · Fixed by #53
Assignees
@clue
Labels
help wanted new feature
Milestone
v1.0.0

Comments

@clue
Copy link
Owner

clue commented Jun 17, 2015

Depends on #4 (uses raw streams?)
@clue clue modified the milestone: v0.3.0 Jun 18, 2015
@clue clue self-assigned this Aug 28, 2015
@clue
Copy link
Owner Author

clue commented Aug 28, 2015

After investigating this further it turns out this behaves very similar to the containerAtach API endpoint (#13) and uses the same framing protocol if TTY mode is not enabled.

I'll look into this.

@clue
Copy link
Owner Author

clue commented Aug 31, 2015

Looks like many API clients resort to using the inspection API to check whether TTY mode is enabled for the given container.

https://github.com/docker/docker-py/pull/669/files
https://github.com/docker/docker/blob/master/api/client/logs.go

@clue
Copy link
Owner Author

clue commented Aug 31, 2015

  • TTY disabled (default) - multiplexed stream, uses application/octet-stream content-type
  • TTY enabled - raw plaintext stream, uses text/plain content-type

@clue
Copy link
Owner Author

clue commented Aug 31, 2015

Turns out this works very similar to #13:
http://stackoverflow.com/questions/26149594/what-is-the-difference-between-docker-logs-and-docker-attach

@clue clue mentioned this issue Apr 19, 2016
Closed
This was referenced Apr 27, 2016
Closed
Open
@clue clue mentioned this issue Sep 18, 2019
Merged
@clue clue closed this as completed in #53 Sep 18, 2019
@clue clue modified the milestones: v0.3.0, v1.0.0 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clue clue

Labels
help wanted new feature
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add containerLogs() and containerLogsStream() methods clue-labs/reactphp-docker
1 participant
@clue