Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject streaming API endpoints if message indicates an error #21

Closed
clue opened this issue Jun 21, 2015 · 3 comments
Closed

Reject streaming API endpoints if message indicates an error #21

clue opened this issue Jun 21, 2015 · 3 comments

Comments

@clue
Copy link
Owner

clue commented Jun 21, 2015

Currently, we only respect the HTTP status codes to detect error conditions. This works for most error conditions – however, this breaks for streaming API endpoints such as pulling an image.

Pulling a non-existant image returns a success status code, however its status events eventually resolve with a message stream like this:

update: {"status":"Pulling repository clue\/does-not-exist"}
update: {"errorDetail":{"message":"Error: image clue\/does-not-exist: not found"},"error":"Error: image clue\/does-not-exist: not found"}

Also refs #4

@clue
Copy link
Owner Author

clue commented Jun 21, 2015

Is this only applicable to JSON streaming? If so, this should probably be resolved as part of #9.

@clue clue mentioned this issue Jun 30, 2015
@clue
Copy link
Owner Author

clue commented Jul 10, 2015

Will be closed via #9 (see 4b21ae4)

@clue
Copy link
Owner Author

clue commented Jul 12, 2015

Closed via #9

@clue clue closed this as completed Jul 12, 2015
@clue clue added this to the v0.2.0 milestone Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant