Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

add sync popular modules, close #468 #472

Merged
merged 2 commits into from
Oct 13, 2014
Merged

add sync popular modules, close #468 #472

merged 2 commits into from
Oct 13, 2014

Conversation

dead-horse
Copy link
Member

  • add sync popular modules
    • config.syncPopular
    • config.syncPopularInterval
    • topPopular
  • change ms to humanize-ms

@dead-horse dead-horse added this to the 1.0 milestone Oct 12, 2014
fengmk2
fengmk2 reviewed Oct 13, 2014
View reviewed changes
sync/index.js
logger.syncInfo(data);
}
if (!config.debug) {
sendMailToAdmin(error, data, new Date());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

沒有錯誤還發郵件？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能会有同步失败的，但是没有错误。 sendMail 里面的逻辑会处理

@fengmk2 fengmk2 added the feat label Oct 13, 2014
fengmk2 added a commit that referenced this pull request Oct 13, 2014
@fengmk2
Merge pull request #472 from cnpm/issue468-upon
05c6d7b 
add sync popular modules, close #468
@fengmk2 fengmk2 merged commit 05c6d7b into master Oct 13, 2014
@fengmk2 fengmk2 deleted the issue468-upon branch October 13, 2014 03:54
@fengmk2
Copy link
Member

fengmk2 commented Oct 13, 2014

@dead-horse 你跟安琪給我的微信發一個數字: 396892 , 在線等...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

Labels
feat
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dead-horse @fengmk2