-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Software Updates: integrate new "reboot" configuration option from dnf-automatic #18593
Comments
Hey @ishimko . I think before automatically rebooting there is a check in the second line of the following script using grep -q.
|
Hi @omarY23, apologize for my mistake, you're right. I was almost sure I experienced reboot without any updates being installed, but now I am checking logs and see that there were updates, so this However I still believe it could be beneficial to switch to the new documented option, even though current solution seems to provide the same behavior. For instance there could be a UI dropdown list which allows selecting from I am good closing this issue as it is not accurate with it's current wording. UDP: the title is accurate, but not description to be precise, I'll better update description so that maintainers could make a decision whether they want this "hack" to be fixed this way or not. |
No worries @ishimko. By the way, the point you raised was right according to me. The auto rebooting could be enhanced using the new reboot option. I think @KKoukiou could tell you better if this is needed or not. |
Using the standard provided mechanism is much preferred, as this feature is relatively new we'd need to handle old and new dnf. |
This was done in PR #19648 |
Page: Software Updates
Currently automatic reboot after installing updates is achieved by a custom script, which does check whether something was installed or not via searching for a
===========
sequence:cockpit/pkg/packagekit/autoupdates.jsx
Lines 183 to 190 in 07e5edf
The bug mentioned in a code comment mentions that a new option
reboot
was added toautomatic.conf
: rpm-software-management/dnf#1879, which can be used instead (when-changed
flag gives this behavior).The text was updated successfully, but these errors were encountered: