Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: Hide "limited access mode" banner without superuser bridges #21135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinpitt
Copy link
Member

When a user configures shell.override.json to disable superuser bridges ({ "bridges": [] }), then the banner in the overview is just inactionable noise. Hide it then.

Fixes #21134

@katodo
Copy link

katodo commented Oct 18, 2024

Thanks! I see the patch is still under review, in the meantime I'll try it out by hand on my system.

@martinpitt
Copy link
Member Author

ah yes - Debian has a motd by default, which is also an alert.

When a user configures shell.override.json to disable superuser bridges
(`{ "bridges": [] }`), then the banner in the overview is just
inactionable noise. Hide it then.

Fixes cockpit-project#21134
@martinpitt
Copy link
Member Author

const compute_configured = () => {
if (proxy.Current == "init")
return null;
return (proxy.Bridges?.length ?? 0) > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test.

@katodo
Copy link

katodo commented Oct 18, 2024

@katodo You are welcome to try the RPMs: https://copr.fedorainfracloud.org/coprs/packit/cockpit-project-cockpit-21135/

Next week I'll try to install a Fedora VM, right now I only have Debian machines (and if I want Ubuntu but that's another story :) )

@katodo
Copy link

katodo commented Oct 18, 2024

@katodo You are welcome to try the RPMs: https://copr.fedorainfracloud.org/coprs/packit/cockpit-project-cockpit-21135/

I couldn't resist :)

I installed a Fedora 40, created a second user "user" without privileges and in its home I created the file ~/.config/cockpit/shell.override.json with
{ "bridges": [] }
inside

At this point if I log in as "user" I see the screen below without the banner, if I log in with my user it allows me to escalate privileges.

image

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overview: Hide "webconsole is running in limited access mode" when there are no superuser bridges
3 participants