Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: github-CI is currently broken due to missing plpgsql build rules #101544

Closed
knz opened this issue Apr 14, 2023 · 6 comments · Fixed by #101930
Closed

build: github-CI is currently broken due to missing plpgsql build rules #101544

knz opened this issue Apr 14, 2023 · 6 comments · Fixed by #101930
Assignees
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@knz
Copy link
Contributor

knz commented Apr 14, 2023

Describe the problem

The "Github CI" / "Lint" target in TC is currently failing on master with the following error:

[15:47:57] :			 [run] # github.com/cockroachdb/cockroach/pkg/sql/scanner
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:35:23: undefined: lexbase.SCONST
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:43:23: undefined: lexbase.IDENT
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:50:23: undefined: lexbase.SCONST
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:60:24: undefined: lexbase.BCONST
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:71:23: undefined: lexbase.DOT_DOT
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:83:23: undefined: lexbase.NOT_EQUALS
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:92:23: undefined: lexbase.LESS_LESS
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:96:23: undefined: lexbase.LESS_EQUALS
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:105:23: undefined: lexbase.GREATER_GREATER
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:109:23: undefined: lexbase.GREATER_EQUALS
[15:47:57] :			 [run] pkg/sql/scanner/plpgsql_scan.go:109:23: too many errors

To Reproduce

Example here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_Check/9610026?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

Expected behavior

No error

Jira issue: CRDB-27002

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels Apr 14, 2023
@e-mbrown
Copy link
Contributor

Weird, this may be caused by go code not being generated before this linter runs. I'll take a look today.

@rickystewart
Copy link
Collaborator

Regressor seems to be 19b6cb96436a5cc7a5c25632f15b4b5df496d6bd.

@rickystewart
Copy link
Collaborator

The commit seemed to introduce some non-trivial build logic so we would have to port it over to make in this case.

@rafiss
Copy link
Collaborator

rafiss commented Apr 24, 2023

Are we still supporting the Makefile on master? If not, when would we stop running the Github CI job?

@knz
Copy link
Contributor Author

knz commented Apr 24, 2023

The linter in github CI is still catching more than the one in bazel. we have a bazel item left to investigate that, it's AFAIK the remaining blocker.

@rickystewart
Copy link
Collaborator

GitHub CI still does GCAssert. #65485

Unfortunately I tried to set up a Bazel-based GCAssert job but it was flaky and no one has been able to identify the source of the flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants