Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: update Sequelize Support to 4.x #33192

Closed
BramGruneir opened this issue Dec 17, 2018 · 3 comments
Closed

sql: update Sequelize Support to 4.x #33192

BramGruneir opened this issue Dec 17, 2018 · 3 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues.

Comments

@BramGruneir
Copy link
Member

Currently we support only version 3.x.
We need to update our support to 4.0 and give it the full Hibernate treatment. Find all the rough edges and get a nightly test going.

This may also require updating the npm sequelize-cockroachdb package as well.
@BramGruneir BramGruneir added this to the 2.2 milestone Dec 17, 2018
@BramGruneir BramGruneir mentioned this issue Dec 17, 2018
Closed
16 tasks
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL meta-issue Contains a list of several other issues. labels Dec 17, 2018
@knz knz changed the title Update Sequalize Support to 4.x sql: update Sequelize Support to 4.x Dec 17, 2018
@knz
Copy link
Contributor

knz commented Dec 17, 2018

@BramGruneir thank you for filing the issue!

Do you want to give a shot at enumerating a step-by-step list of what actions are needed for this investigation? And who should carry them out? Thanks

@BramGruneir
Copy link
Member Author

I can try to lay out the step by step instructions, but I'm not familiar with our Sequalize library at all, so that will take some time.

As for who, I think we can sort that out as a team. It may fall onto me, which is fine, we just need to prioritize this.

@awoods187 awoods187 removed this from the 19.1 milestone Mar 22, 2019
@vy-ton
Copy link
Contributor

vy-ton commented Sep 1, 2020

Sequelize v4 is supported see commit

@vy-ton vy-ton closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @BramGruneir @vy-ton @awoods187