You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
erikgrinaker opened this issue
Jan 11, 2022
· 0 comments
· Fixed by #74674
Assignees
Labels
A-kvAnything in KV that doesn't belong in a more specific category.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
ClearRange avoids dropping a Pebble range tombstone if the amount of data that's deleted is small (<=512 KB), instead dropping point deletions. It uses MVCC statistics to determine this. However, when clearing an entire range, it will rely on the existing range MVCC stats rather than computing them.
These range statistics can be highly inaccurate -- in some cases so inaccurate that they even become negative. This in turn can cause ClearRange to submit a huge write batch, which gets rejected by Raft with command too large.
We should check whether the stats are accurate via ContainsEstimates before taking the point deletion path.
The text was updated successfully, but these errors were encountered:
erikgrinaker
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
A-kv
Anything in KV that doesn't belong in a more specific category.
T-kv-replication
labels
Jan 11, 2022
A-kvAnything in KV that doesn't belong in a more specific category.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
ClearRange
avoids dropping a Pebble range tombstone if the amount of data that's deleted is small (<=512 KB), instead dropping point deletions. It uses MVCC statistics to determine this. However, when clearing an entire range, it will rely on the existing range MVCC stats rather than computing them.These range statistics can be highly inaccurate -- in some cases so inaccurate that they even become negative. This in turn can cause
ClearRange
to submit a huge write batch, which gets rejected by Raft withcommand too large
.We should check whether the stats are accurate via
ContainsEstimates
before taking the point deletion path.The text was updated successfully, but these errors were encountered: