Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic for schema registry appears broken #77480

Closed
steven-hubbard opened this issue Mar 8, 2022 · 3 comments
Closed

Retry logic for schema registry appears broken #77480

steven-hubbard opened this issue Mar 8, 2022 · 3 comments
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc

Comments

@steven-hubbard
Copy link
Contributor

steven-hubbard commented Mar 8, 2022

POSTs sent as part of a retry contain no body. Steps to reproduce:

  1. Create a changefeed to a kafka sink using a schema registry
  2. CRDB goes to register a schema
  3. The schema registry returns 200 but only the ID due to an invalid body (due to a malformed request)
  4. CRDB issues retries but all subsequent retries only contain the ID, no body.

I think retries here are broken because the first attempt consumes the bytes.Buffer, so subsequent attempts are made with an empty POST body

Jira issue: CRDB-13618

Epic CRDB-11783

@steven-hubbard steven-hubbard added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 8, 2022
@miretskiy
Copy link
Contributor

I think retries here are broken because the first attempt consumes the bytes.Buffer, so subsequent attempts are made with an empty POST body

I don't think that's true. http Post creates new reader for the buffer.

@rafiss rafiss added the T-cdc label Jul 17, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 17, 2023

cc @cockroachdb/cdc

@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Jul 17, 2023
@jayshrivastava
Copy link
Contributor

Fixed by #98135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
None yet
Development

No branches or pull requests

4 participants