Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add range del invariants to TestMVCCHistories #86122

Closed
tbg opened this issue Aug 15, 2022 · 1 comment · Fixed by #86390
Closed

storage: add range del invariants to TestMVCCHistories #86122

tbg opened this issue Aug 15, 2022 · 1 comment · Fixed by #86390
Assignees
@tbg
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@tbg
Copy link
Member

tbg commented Aug 15, 2022 •
edited by exalate-issue-sync bot
Loading

Add internal invariant checks to TestMVCCHistories:

On Seek, Next, Prev:

  • step in reverse direction and then back and/or
  • re-seek to the current key
  • seek to prev key and step back until we see current key
  • probably more that we could do

This should leave the iterator in the same state, so by turning this on metamorphically we can validate that this is true.

Jira issue: CRDB-18587

Epic CRDB-2624
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication labels Aug 15, 2022
@tbg tbg self-assigned this Aug 15, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 15, 2022

cc @cockroachdb/replication

@blathers-crl blathers-crl bot added the A-kv-replication Relating to Raft, consensus, and coordination. label Aug 15, 2022
@tbg tbg mentioned this issue Aug 22, 2022
Merged
@craig craig bot closed this as completed in d278d09 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: introduce metamorphic iterator tbg/cockroach
1 participant
@tbg