Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: underscore / emphasize status of storage.mvcc.range_tombstones.enabled cluster setting #91001

Closed
nicktrav opened this issue Oct 31, 2022 · 0 comments · Fixed by #91011
Closed

storage: underscore / emphasize status of storage.mvcc.range_tombstones.enabled cluster setting #91001

nicktrav opened this issue Oct 31, 2022 · 0 comments · Fixed by #91011
Assignees
@jbowens
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented Oct 31, 2022 •
edited by exalate-issue-sync bot
Loading

Is your feature request related to a problem? Please describe.

This came up in the release blockers meeting on 10/31.

There exists the storage.mvcc.range_tombstones.enabled cluster, controlling whether or not we write range tombstones (to enable various MVCC bulk ops enhancements). By default this cluster setting is off.

Ideally, no-one should be toggling this flag unless they know what to expect, and what to monitor.

Describe the solution you'd like

Make the documentation abundantly clear that this cluster setting should be treated as "internal only".

Jira issue: CRDB-21066

Epic CRDB-20465
@nicktrav nicktrav added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team labels Oct 31, 2022
@blathers-crl blathers-crl bot added the A-storage Relating to our storage engine (Pebble) on-disk storage. label Oct 31, 2022
@exalate-issue-sync exalate-issue-sync bot removed the A-storage Relating to our storage engine (Pebble) on-disk storage. label Oct 31, 2022
@nicktrav nicktrav added the A-storage Relating to our storage engine (Pebble) on-disk storage. label Oct 31, 2022
@jbowens jbowens mentioned this issue Oct 31, 2022
Merged
@craig craig bot closed this as completed in 14249a5 Nov 1, 2022
This was referenced Nov 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbowens jbowens

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: adjust range tombstone language to encourage caution jbowens/cockroach
2 participants
@nicktrav @jbowens