Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: allow parsing of CREATE FUNCTION LANGUAGE pl/pgsql, before supporting the full grammar #96720

Closed
rafiss opened this issue Feb 7, 2023 · 0 comments · Fixed by #96726
Closed

sql: allow parsing of CREATE FUNCTION LANGUAGE pl/pgsql, before supporting the full grammar #96720

rafiss opened this issue Feb 7, 2023 · 0 comments · Fixed by #96726
Assignees
@rafiss
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Feb 7, 2023 •
edited by cockroach-jira-scripts
Loading

If we could parse statements that have LANGUAGE pl/pgsql, rather than returning a syntax error, then we would be able to see them in telemetry data. We should be able to do this before supporting the pl/pgsql grammar itself. Basically, we can move the error to happen after parsing instead of during parsing.

Jira issue: CRDB-24295
@rafiss rafiss added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 7, 2023
@rafiss rafiss self-assigned this Feb 7, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Feb 7, 2023
This was referenced Feb 7, 2023
Merged
Closed
@craig craig bot closed this as completed in 0a65a4e Feb 7, 2023
@rafiss rafiss mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: use unimplemented error rather than syntax error for PL/pgSQL rafiss/cockroach
1 participant
@rafiss