Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limitations section to documentation for Go / pgx #7715

Open
chriscasano opened this issue Jul 7, 2020 · 7 comments · Fixed by #7698
Open

Add limitations section to documentation for Go / pgx #7715

chriscasano opened this issue Jul 7, 2020 · 7 comments · Fixed by #7698
Labels
C-doc-improvement O-sales-eng Internal source: Sales Engineering P-2 Normal priority; secondary task T-missing-info

Comments

@chriscasano
Copy link
Contributor

chriscasano commented Jul 7, 2020

Chris Casano (chriscasano) commented:

At times, we've directing users to pgx from lib/pq. However, we don't have documentation around pgx, what it's capabilities are and what is lacking. An example would be items like this: cockroachdb/cockroach#19603. Most users wouldn't know this limitation until they hit it.

Jira Issue: DOC-584

@jseldess
Copy link
Contributor

jseldess commented Jul 7, 2020

@ericharmeling, @vy-ton, passing to you for triage and prioritization. I have a feeling you're already working on pgx support/docs.

@vy-ton
Copy link
Contributor

vy-ton commented Jul 7, 2020

Yes, Eric has a in-progress PR. @ericharmeling Can you add a limitations section for pgx?

@ericharmeling
Copy link
Contributor

Yes, Eric has a in-progress PR. @ericharmeling Can you add a limitations section for pgx?

Sure thing. Thanks for the notice!

@vy-ton vy-ton added the P-1 High priority; must be done this release label Jul 15, 2020
@vy-ton vy-ton linked a pull request Jul 15, 2020 that will close this issue
@ericharmeling ericharmeling changed the title Add documentation for Go / pgx Add limitations section to documentation for Go / pgx Jul 16, 2020
@ericharmeling
Copy link
Contributor

@chriscasano

I can add a "Limitations" section to our pgx tutorial (not yet published). It would be helpful to have a list of said limitations ahead of creating that PR. cockroachdb/cockroach#19603 seems to be a limitation of lib/pq (i.e., a reason for switching over the pgx), rather than a limitation of pgx.

Re: pgx capabilities, I think we should point to pgx documentation (https://github.com/jackc/pgx#features) for a list of the library's capabilities rather than duplicating that information on our docs. I can add a link to that README.

@chriscasano
Copy link
Contributor Author

👍

@vy-ton
Copy link
Contributor

vy-ton commented Jul 20, 2020

cockroachdb/cockroach#19603 seems to be a limitation of lib/pq (i.e., a reason for switching over the pgx), rather than a limitation of pgx.

@ericharmeling It's not a limitation with pgx but instead CockroachDB's usage with pgx since we don't support the COPY BINARY. Probably worth highlighting this so that users using pgx's COPY know that it won't work.

@maddyblue
Copy link
Contributor

We just merged BINARY support, so we should be able to document this better now?

@ericharmeling ericharmeling added P-2 Normal priority; secondary task and removed P-1 High priority; must be done this release labels Oct 28, 2020
@jseldess jseldess removed the G-sql label Jan 18, 2022
@exalate-issue-sync exalate-issue-sync bot changed the title Add limitations section to documentation for Go / pgx Add limitations section to documentation for Go / pgx Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-doc-improvement O-sales-eng Internal source: Sales Engineering P-2 Normal priority; secondary task T-missing-info
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants