Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] git-email values with spaces, even when double-quoted, cause failed builds #28

Open
nharward opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nharward
Copy link

nharward commented Aug 19, 2024

Describe the bug
Specifying a value of git-user with spaces, even wrapped with double-quotes, fails the action when run.

To Reproduce
Use a value for git-user such as My User or "My User". Run the action, only the first word will be used as the git-user argument and the next word as the value for git-email.

Expected behavior
The YAML string, quoted or not, as defined in the GHA workflow file should be used as the value for git-commit.

Additional context
I believe the issue is in the cog step of action.yml, specifically that the action inputs are not quoted when calling cog.sh. I suspect wrapping each of those arguments in double quotes would resolve the issue.

@nharward nharward added the bug Something isn't working label Aug 19, 2024
@nharward nharward changed the title [BUG] [BUG] git-email values with spaces, even when double-quoted, cause failed builds Aug 19, 2024
@eshepelyuk
Copy link

Hello @nharward
Will you be interested to try my maintained fork https://github.com/eshepelyuk/cocogitto-diya

This bug is fixed there together with other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants