Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCE-1040] Default value for parameter 'registry-address' breaking default behavior #130

Closed
KB1RMA opened this issue Jul 11, 2024 · 3 comments

Comments

@KB1RMA
Copy link

KB1RMA commented Jul 11, 2024

It looks like the new registry-address parameter just introduced in #129 has broken the default behavior of this action. Since the value is set to "gh" by default - it now tries to pull docker images from ghcodacy namespace rather than codacy

Logs from an actions run using codacy/codacy-analysis-cli-action@v4

Status: Downloaded newer image for codacy/codacy-analysis-cli:7.9.10
07/11 12:16:40 ERROR c.c.a.c.a.CodacyPluginsAnalyser:31 - Failed analysis for pmd 
java.lang.Throwable: 
Docker exited with code 125
stdout: 
stderr: Unable to find image 'ghcodacy/codacy-pmd:3.13.13' locally
docker: Error response from daemon: pull access denied for ghcodacy/codacy-pmd, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Unfortunately this isn't avoidable since if we pass in an empty value to the action, it reverts back to the default

@github-actions github-actions bot changed the title Default value for parameter 'registry-address' breaking default behavior [TCE-1040] Default value for parameter 'registry-address' breaking default behavior Jul 11, 2024
Copy link

Internal ticket created : TCE-1040

@hjrocha
Copy link
Contributor

hjrocha commented Jul 11, 2024

Just pushed a PR with a fix. Thanks for the heads up

@hjrocha hjrocha closed this as completed Jul 11, 2024
@KB1RMA
Copy link
Author

KB1RMA commented Jul 11, 2024

@hjrocha just confirmed it's fixed for us. Appreciate the quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants