Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [TCE-1039] Add parameter 'registryAddress' in order to support alternative registry addresses #511

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hjrocha
Copy link
Contributor

@hjrocha hjrocha commented Jul 11, 2024

…try addresses

@hjrocha hjrocha requested a review from a team as a code owner July 11, 2024 09:56
Copy link

codacy-production bot commented Jul 11, 2024

Summary

This pull request introduces a new parameter registryAddress to support alternative registry addresses.

Changes

  • The AnalyseExecutor class now accepts a new parameter registryAddress in its constructor.
  • The ToolSelector class now accepts a new parameter registryAddress in its allTools method.
  • The CLIConfiguration object now has a new field registryAddress in its constructor.
  • The ToolSelectorSpec test file has been updated to include the new registryAddress parameter.
  • The CLIConfigurationSpec test file has been updated to include the new registryAddress field.

Conclusion

This pull request adds support for alternative registry addresses, allowing users to specify a custom registry address when running the analysis.


This comment was generated by an experimental AI tool (winner of the 2024 Codacy Hackathon 'People's Choice' and 'Most Valuable' awards).

@hjrocha hjrocha requested a review from machadoit July 11, 2024 09:58
Copy link

codacy-production bot commented Jul 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 94.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (097d39b) 1273 1042 81.85%
Head commit (0091e95) 1277 (+4) 1046 (+4) 81.91% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#511) 17 16 94.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@machadoit machadoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if easy to add a test for that case, but it does seems o maintain correctly what we have today, so we can move forward for me!

@hjrocha hjrocha enabled auto-merge July 11, 2024 10:38
@hjrocha hjrocha merged commit 943ea0d into master Jul 11, 2024
8 checks passed
@hjrocha hjrocha deleted the add-custom-registry branch July 11, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants