Fix login process doesn't remember the worksheets page #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzwang43
changed the title
epicfaace
approved these changes
Nov 30, 2021
epicfaace
approved these changes
Nov 30, 2021
| @@ -359,7 +359,12 @@ class NavBar extends React.Component<{ | |||
| <Link to='/account/signup'> | |||
| <Button color='inherit'>Sign Up</Button> | |||
| </Link> | |||
| <Link to='/account/login'> | |||
| <Link | |||
There was a problem hiding this comment.
Should we do the same for the sign up button?
There was a problem hiding this comment.
I think it's outside the scope of this issue. But we can talk about it in the meeting? Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Currently, logging out and back in doesn't bring the user back to the previous worksheet page.
Related issues
fixes #3892
Screenshots
To fix this, we just need to path in the correct props to the login page.
Checklist