Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login process doesn't remember the worksheets page #3895

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix login process doesn't remember the worksheets page #3895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion frontend/src/components/NavBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,12 @@ class NavBar extends React.Component<{
<Link to='/account/signup'>
<Button color='inherit'>Sign Up</Button>
</Link>
<Link to='/account/login'>
<Link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same for the sign up button?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's outside the scope of this issue. But we can talk about it in the meeting? Thanks!

to={{
pathname: '/account/login',
state: { from: this.props.location },
}}
>
<Button color='inherit'>Login</Button>
</Link>
</React.Fragment>
Expand Down