Fix bypass of blob storage downloads with custom bundle stores #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963.
How I tested this manually
Start server:
codalab-service start -bds default azuriteIn Web CLI, add blob storage store:
cl store add --name blob --storage-type azure_blob --url azfs://devstoreaccount1/bundlescl upload --store blob -c test. View the bundle contents (download the bundle) on the website and it should redirect to Azurite (localhost:10000):cl upload -a -c test. View the bundle contents on the website and it should also redirect to Azurite (localhost:10000).Previously, the issue with #3963 was that 2) would properly redirect and 1) would not properly redirect. Hope this helps as an explanation of #3963 @pranavjain !