Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description for args #4006

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Update description for args #4006

merged 3 commits into from
Apr 18, 2022

Conversation

epicfaace
Copy link
Member

Update descriptions from #4005 to be more accurate

@epicfaace epicfaace changed the title Update description for args Update description for args, fix docker-compose mounts Feb 17, 2022
@epicfaace epicfaace changed the title Update description for args, fix docker-compose mounts Update description for args Feb 17, 2022
@epicfaace
Copy link
Member Author

Please review when you get a chance @teetone

@epicfaace epicfaace requested a review from wwwjn April 18, 2022 18:49
@wwwjn
Copy link
Contributor

wwwjn commented Apr 18, 2022

It seems that this PR needs to rebase

@epicfaace
Copy link
Member Author

epicfaace commented Apr 18, 2022

@wwwjn if you label a PR "ready-to-merge", then once it's approved and CI passes, Mergify will automatically update the branch and then merge it.

@wwwjn
Copy link
Contributor

wwwjn commented Apr 18, 2022

That's cool! I use to manually rebase and I will try "ready-to-merge" label in the future PRs.

@mergify mergify bot merged commit 7a04b5a into master Apr 18, 2022
@mergify mergify bot deleted the epicfaace-patch-8 branch April 18, 2022 19:47
@teetone teetone mentioned this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants