-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worksheet View UI Optimizations #4343
Conversation
@percyliang ready for your eyes 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is great - really nice work! A few minor things that I ran into while playing with it:
- Could we make the New Run modal take up a bit more of the screen?
- If the user closes 'New Run', I wonder if it would make sense to keep the state around (in case they were typing a long command) so their work doesn't get lost? It doesn't complicate things, so not super opinionated about this, but thought I'd bring it up.
- 'Enter' doesn't work any more as a hot key to open up a bundleo
- Could we have 'u' go back to the worksheet page from the bundle view like in Gmail?
- When you go back to the worksheets page, it should keep the scroll exactly where you came from (currently, it scrolls to the top)
- When you hit rerun, it takes you to a bundle page, but the scroll position is not at the top (it should be)
- After hitting rerun, when hit 'Back', the cursor isn't anywhere (it should be on the bundle that we just came from)
- When you load a worksheet, a blue bar should show at the top of the worksheet to denote that the cursor is before any bundle (this used to be there but is gone now)
- When you hit 'gg' at the end of a worksheet that doesn't fit on one page, focus doesn't follow to the top of the worksheet (this was working before)
Some other bugs that I noticed (not related to this PR), but just putting them here for now:
- Keyboard shortcuts scrolls off the end of the page
- When you hold down 'j' or 'k' to scroll, the cursor position freezes instead of moving up/down the page gracefully as if you were in a text editor
done
Currently, the
fixed
You can now use
fixed
fixed
fixed
fixed
fixed
Are you referring to the Keyboards Shortcuts modal that pops open when you click the shortcut info icon? If so, you can scroll to see the rest of the info. It appears that this implementation was intentional.
Hm. Not sure how useful this would be. |
This is great! Two more things I noticed:
|
fixed
This works on my end: 20221226173045373.mp4 |
Interesting, that page works for me too, but if you create a new worksheet and create one bundle and then replicate it 100x times (probably easiest to do Raw Edit and copy/paste in the editor), then I think this should reproduce the bug. |
@percyliang should be fixed now |
@percyliang yikes 😅 fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work now. :-) Thanks for this great change - the interface feels so much more tight and natural!
@percyliang so glad you like it! 😃 |
Major Changes
/worksheets/:uuid
route now accepts an optional:bundle_uuid
param.NewRun
view in place. TheNewRun
view will now open in a modal.Minor Changes
Related issues
#4300
Demo
20221223143055910.mp4
Checklist