Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click Area of "Click Me" button does not work on every browser "Samsung Browser" #49

Closed
Nicuschgifthub opened this issue Feb 13, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Nicuschgifthub
Copy link
Member

When clicking the button by just touching a corner it does light up as beeing clicked but nothing opens in response to the interaction, depending on how far of you are from the center of the visible button.

@Knerio
Copy link
Member

Knerio commented Feb 13, 2024

So on chrome android version 13 it works better but the error still occurs in some cases

@nicosammito
Copy link
Contributor

It could relate to the wrapper that is not working as intended:

<div ref={triggerRef}>
{menuTrigger ? React.cloneElement(menuTrigger.props.children, {...buttonProps, tabIndex: 1}) : null}
</div>

@nicosammito nicosammito self-assigned this Feb 13, 2024
@nicosammito nicosammito added the bug Something isn't working label Feb 13, 2024
@nicosammito nicosammito linked a pull request Feb 13, 2024 that will close this issue
@nicosammito
Copy link
Contributor

It’s a general Issue on all browsers. Trying to move the menuTrigger props to the wrapper. Thus could potentially fix this issue

@nicosammito
Copy link
Contributor

This is an issue inside of Aria. Hopefully they fix it soon:

adobe/react-spectrum#1061

@nicosammito nicosammito removed a link to a pull request Feb 13, 2024
@nicosammito
Copy link
Contributor

We can close this for now, because aria will not fix this any soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants