Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live chatting feature #316

Open
mvp5464 opened this issue May 10, 2024 · 4 comments
Open

Live chatting feature #316

mvp5464 opened this issue May 10, 2024 · 4 comments

Comments

@mvp5464
Copy link

mvp5464 commented May 10, 2024 •
edited
Loading

Live chatting feature to communicate between two players

chessMessage2.webm
@nimit9
Copy link
Contributor

nimit9 commented May 10, 2024

Implemented in #198

@Airbornharsh Airbornharsh mentioned this issue May 10, 2024
Open
@mvp5464
Copy link
Author

mvp5464 commented May 11, 2024

Implemented in #198

Ohk, Don't know about it, So removing the Pr.
(apologise for late replay as I was on tour)

@mvp5464
Copy link
Author

mvp5464 commented May 11, 2024

Hi @nimit9, I saw the Pr you mentioned, many features are shoved into one and I used different approach for UI with toggle mode.

  • So, should I change the Pr as "UI update for chess live messaging" or let Sir review it as it is. (no bounty needed but UI looks good your take on it.)

Screenshot from 2024-05-11 22-10-47
Screenshot from 2024-05-11 22-11-07

@nimit9
Copy link
Contributor

nimit9 commented May 11, 2024

Yeah, you can reopen it and let @hkirat review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvp5464 @nimit9