Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Implementation of Encryption of shares #136

Closed
axatbhardwaj opened this issue Aug 28, 2024 · 6 comments · Fixed by #162
Closed

[Feat] Implementation of Encryption of shares #136

axatbhardwaj opened this issue Aug 28, 2024 · 6 comments · Fixed by #162
Labels
enhancement New feature or request feature good first issue Good for newcomers

Comments

@axatbhardwaj
Copy link
Collaborator

Todo:-

  1. encrypt shares using best encryption algo/method to encrypt

before starting with implementation would love to have a small research note (notion doc preferably) on how you've chosen a specific Algo/method for encryption and why

after the discussion would assign the issue then you can start implementing

it is not to scrutinize anyone just to make rational decision

@axatbhardwaj axatbhardwaj added enhancement New feature or request good first issue Good for newcomers feature labels Aug 28, 2024
@Sahid-m
Copy link

Sahid-m commented Aug 29, 2024

Do you mean encryption of private key shards or what is share in this context? Would like to work on this but need some clarity before researching for encryption algorithm

@axatbhardwaj
Copy link
Collaborator Author

axatbhardwaj commented Sep 2, 2024

Do you mean encryption of private key shards or what is share in this context? Would like to work on this but need some clarity before researching for encryption algorithm

yes

i meant the shares of private key only and i think it(documentation) is available on the notion doc present in project readme

Please let me know it isn't

Cheers !!

@lakshayvaishnav
Copy link
Contributor

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.

notion doc

Please take a look when you have a chance and let me know if you have any feedback!

@axatbhardwaj
Copy link
Collaborator Author

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.

notion doc

Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

@lakshayvaishnav
Copy link
Contributor

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.
notion doc
Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

well , first of all it is really tough to crack because of its strong encryption , it is faster and efficient as compared to other algos so it wont slow down our dapp and lastly it is widely accepted and trusted by many other blockchain platforms and web3 projects.

@axatbhardwaj
Copy link
Collaborator Author

hey @axatbhardwaj , I've created a Notion document that outlines various encryption methods suitable for encrypting the shards in our project.
notion doc
Please take a look when you have a chance and let me know if you have any feedback!

Hi @lakshayvaishnav

Thank you for the doc and i would love to know in a few lines why should we use AES256 for symmetric encryption and not any other algo

well , first of all it is really tough to crack because of its strong encryption , it is faster and efficient as compared to other algos so it wont slow down our dapp and lastly it is widely accepted and trusted by many other blockchain platforms and web3 projects.

clone and look at the encryption branch from the repo

let's connect over discord if you have some doubts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants