From 5e7926c9dc3bf1be7c87ad89233c85626b66c2fd Mon Sep 17 00:00:00 2001 From: Jonas Hecht Date: Thu, 4 Feb 2021 21:17:10 +0100 Subject: [PATCH] #1622: Fixing `Unknown lifecycle phase ".javadoc.skip=true"` error on Windows builds. --- .github/workflows/build-feature.yml | 4 +++- .github/workflows/build-main.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-feature.yml b/.github/workflows/build-feature.yml index f6d046e1cc4..e1cc19dfd62 100644 --- a/.github/workflows/build-feature.yml +++ b/.github/workflows/build-feature.yml @@ -23,5 +23,7 @@ jobs: with: java-version: 1.8 + # since we also build on Windows Powershell, we need to add a space between -D maven.javadoc.skip=true + # otherwise the build will fail https://stackoverflow.com/questions/38051787/maven-javadoc-skip-true-throws-an-error - name: Build with Maven - run: mvn -B install --no-transfer-progress -Dmaven.javadoc.skip=true + run: mvn -B install --no-transfer-progress -D maven.javadoc.skip=true diff --git a/.github/workflows/build-main.yml b/.github/workflows/build-main.yml index 61e07fa58f7..0574d3d7448 100644 --- a/.github/workflows/build-main.yml +++ b/.github/workflows/build-main.yml @@ -23,8 +23,10 @@ jobs: with: java-version: 1.8 + # since we also build on Windows Powershell, we need to add a space between -D maven.javadoc.skip=true + # otherwise the build will fail https://stackoverflow.com/questions/38051787/maven-javadoc-skip-true-throws-an-error - name: Build with Maven - run: mvn -B install --no-transfer-progress -Dmaven.javadoc.skip=true + run: mvn -B install --no-transfer-progress -D maven.javadoc.skip=true publish-snapshot: needs: build