Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov bot is posting very old updates to our repo #497

Closed
jhamman opened this issue Aug 30, 2024 · 8 comments
Closed

Codecov bot is posting very old updates to our repo #497

jhamman opened this issue Aug 30, 2024 · 8 comments
Assignees
Labels
Area: PR Comment - UX Issues with the PR Comment UX bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints)

Comments

@jhamman
Copy link

jhamman commented Aug 30, 2024

Describe the bug
Our GitHub project (zarr-developers/zarr-python) has recently started receiving codecov bot updates literally years after PRs were closed.

Environment (please complete the following information):

  • Browser [e.g. chrome, safari] (if applicable)
  • System: GitHub

To Reproduce
Go to one of these PRs and observe the very late bot post:

Expected behavior
It seems the bot failed to make a timely update to these PRs. Expected behavior would be that 2 year old PRs don't get bot updates.

Screenshots

Image

Additional context

Our tracking issue: zarr-developers/zarr-python#2138

@jhamman jhamman changed the title Bug Report Codecov bot is posting very old updates to our repo Aug 30, 2024
@rohan-at-sentry rohan-at-sentry added bug For issues and unexpected behaviors and removed Waiting for: Product Owner labels Sep 4, 2024
@eliatcodecov
Copy link
Contributor

@drazisil-codecov to investigate, we'll figure out next steps once we have more clarity on the underlying issue.

@eliatcodecov eliatcodecov added the High High Priority Issues (to be fixed within 2 sprints) label Sep 4, 2024
@eliatcodecov eliatcodecov added Area: PR Comment - UX Issues with the PR Comment UX and removed bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints) labels Sep 4, 2024
@codecov-hooky codecov-hooky bot added bug For issues and unexpected behaviors labels Sep 4, 2024
@eliatcodecov eliatcodecov added High High Priority Issues (to be fixed within 2 sprints) and removed bug For issues and unexpected behaviors Area: PR Comment - UX Issues with the PR Comment UX labels Sep 4, 2024
@codecov-hooky codecov-hooky bot added bug For issues and unexpected behaviors labels Sep 4, 2024
@eliatcodecov eliatcodecov added the Area: PR Comment - UX Issues with the PR Comment UX label Sep 4, 2024
@drazisil-codecov
Copy link

@jhamman It looks like GitHub says the PR was updated. https://api.github.com/repos/zarr-developers/zarr-python/pulls/1023

Codecov responded to a status web hook from GitHub. Any idea what might have changed?

@jhamman
Copy link
Author

jhamman commented Sep 9, 2024

Any idea what might have changed?

No. The last change was over 2 years ago. Are you sure the "updated_at" field is not coming from Codecov's comment?

@drazisil-codecov
Copy link

Any idea what might have changed?

No. The last change was over 2 years ago. Are you sure the "updated_at" field is not coming from Codecov's comment?

Hmm, that's possible. 🤦

I did see a hook in the log though... 👀

@drazisil-codecov
Copy link

Hook Delivery id: e0b53a3a-6517-11ef-94eb-86bf97e52810 was received by Codecov at 2024-08-28T08:31:10.979108533Z

We don't log the exact payloads for sanity reasons, but that is what trigged us to send the comment. Hopefully GitHub support may be able to tell you what triggered that hook? Unfortunately I have no way to know :-/

@webknjaz
Copy link

Hook Delivery id: e0b53a3a-6517-11ef-94eb-86bf97e52810 was received by Codecov at 2024-08-28T08:31:10.979108533Z

You should be able to check that comment's timestamp and see if it's within milliseconds or earlier than the webhook delivery. If it's after the webhook delivery, then it's not the trigger. But the timestamp seems to correlate, so that comment is likely not the event trigger but a reaction to some other trigger.

@drazisil-codecov
Copy link

Hook Delivery id: e0b53a3a-6517-11ef-94eb-86bf97e52810 was received by Codecov at 2024-08-28T08:31:10.979108533Z

We don't log the exact payloads for sanity reasons, but that is what trigged us to send the comment. Hopefully GitHub support may be able to tell you what triggered that hook? Unfortunately I have no way to know :-/

I forgot to tag @jhamman for this response.

@jhamman
Copy link
Author

jhamman commented Sep 17, 2024

Thanks for looking into this. I don't have time to chase this further right now. If you hypothesis is that something else sent the webhook, I'm happy if you close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: PR Comment - UX Issues with the PR Comment UX bug For issues and unexpected behaviors High High Priority Issues (to be fixed within 2 sprints)
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

5 participants