Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsePath instead of File in the API #47

Open
laeubi opened this issue Oct 5, 2022 · 3 comments
Open

UsePath instead of File in the API #47

laeubi opened this issue Oct 5, 2022 · 3 comments

Comments

@laeubi
Copy link
Collaborator

laeubi commented Oct 5, 2022

To encourage user to use modern API all File references should be replaced by Path references, even though currently due to the Plexus-Scanner-API only File pathes are actually supported.

@laeubi
Copy link
Collaborator Author

laeubi commented Nov 23, 2022

@laeubi
Copy link
Collaborator Author

laeubi commented Nov 24, 2022

Another option would be to get rid of the Scanner API completely and return a DirectoryStream instead ...

@laeubi
Copy link
Collaborator Author

laeubi commented Nov 24, 2022

I have checked m2e and it uses AbstractScanner only (so directory scanner is not really a concern for it and mostly used for the default impl) and mostly uses it to check if a delta found matches.

@kwin as you recently made some plugins Build API aware, I wonder if you can shade some light how useful the methods newScanner/newDeleteScanner are actually are, I feel like we can simply get rid of them completely and just offer a newDeltaStream() that list all items (deleted, new, changed) and then users can use other method of the context to decide what state they actually have (if the implementation itself actually is not using a different filtering mechanism already) ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant