Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot submits Homebrew PRs on the wrong base #3407

Closed
code-asher opened this issue May 17, 2021 · 2 comments · Fixed by #3438
Closed

Bot submits Homebrew PRs on the wrong base #3407

code-asher opened this issue May 17, 2021 · 2 comments · Fixed by #3438
Assignees
Labels
ci Issues related to ci
Milestone

Comments

@code-asher
Copy link
Member

code-asher commented May 17, 2021

I think it might be because brew bump-formula-pr is basing it off cdrci's fork which is outdated. Perhaps there is a flag to pull the latest changes into the fork first or maybe we'll have to do it before running brew.

@code-asher code-asher added the ci Issues related to ci label May 17, 2021
@code-asher code-asher added this to the 3.11.0 milestone May 17, 2021
@code-asher code-asher changed the title cdrci bot submits homebrew PRs on the wrong base Bot submits homebrew PRs on the wrong base May 17, 2021
@code-asher code-asher changed the title Bot submits homebrew PRs on the wrong base Bot submits Homebrew PRs on the wrong base May 17, 2021
@jsjoeio jsjoeio self-assigned this May 18, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented May 21, 2021

Notes

The way this currently works is we use brew bump-formula-pr using @cdrci's GitHub Token (environment variable).
The docs for brew bump-formula-pr: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/bump-formula-pr.rb#L18

@jsjoeio
Copy link
Contributor

jsjoeio commented May 21, 2021

This is because cdrci/homebrew it out of date, right? So why don't we just add some commands to the script:

  • checkout cdr/hombrew
  • pull remote changes
  • update fork
  • run brew bump-formula step

This could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants