Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing some TODOs #133

Closed
czgdp1807 opened this issue Mar 10, 2020 · 4 comments · Fixed by #141
Closed

Removing some TODOs #133

czgdp1807 opened this issue Mar 10, 2020 · 4 comments · Fixed by #141

Comments

@czgdp1807
Copy link
Member

Description of the problem

Currently the master has a TODO task of replacing the collections.deque with pydatastructs.Queue. We have decided not to do this replacement as queue is a very simple data structure and it's efficient implementation is already present in python. In fact, deepcopy.copy will be a bottleneck in doing this replacement so, we shouldn't simply invest our time in this.

Example of the problem

References/Other comments
@Riyagoel2
Copy link
Contributor

I would like to contribute

@czgdp1807
Copy link
Member Author

Sure, please proceed with a PR.

@Riyagoel2
Copy link
Contributor

Can you please provide any reference

@czgdp1807
Copy link
Member Author

For fixing this issue, you just have to look for lines in the codebase having TODO and remove those lines.

@Riyagoel2 Riyagoel2 mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed TODO from 3 files
3 participants
@czgdp1807 @robotjellyzone @Riyagoel2