Issue #49 circular linked list #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
============================================
+ Coverage 97.94% 98.019% +0.078%
============================================
Files 20 20
Lines 1311 1363 +52
============================================
+ Hits 1284 1336 +52
Misses 27 27
|
|
Please resolve the conflicts. |
|
Resolved. |
prshnt19
force-pushed
the
issue_#49_CircularLinkedList
branch
from
f0df79b
to
7bb4305
Compare
czgdp1807
reviewed
Mar 2, 2020
| ========== | ||
|
|
||
| .. [1] https://en.wikipedia.org/wiki/Linked_list#Circular_linked_list | ||
| .. [2] https://www.geeksforgeeks.org/circular-singly-linked-list-insertion/ |
There was a problem hiding this comment.
Suggested change
| .. [2] https://www.geeksforgeeks.org/circular-singly-linked-list-insertion/ |
There was a problem hiding this comment.
The wiki page does not have enough info so I added other references.
There was a problem hiding this comment.
The info on the Wiki is not enough. Should I add a reference from other sites or leave it as it is?
There was a problem hiding this comment.
You can add links to university lectures.
There was a problem hiding this comment.
I have updated Wiki References.
|
@prshnt19 If you want, you can add your name to AUTHORS file in a separate PR. |
czgdp1807
reviewed
Mar 3, 2020
|
LGTM. |
Co-Authored-By: Gagandeep Singh <[email protected]>
|
Tests are correct. I have verified it. |
manaswinidas
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SinglyCircularLinkedList and DoublyCircularLinkedList
References to other Issues or PRs or Relevant literature
#49
Brief description of what is fixed or changed
Other comments