LinkedListQueue Added #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=============================================
+ Coverage 97.821% 97.956% +0.134%
=============================================
Files 20 20
Lines 1423 1468 +45
=============================================
+ Hits 1392 1438 +46
+ Misses 31 30 -1 |
czgdp1807
reviewed
Mar 6, 2020
Comment on lines
56
to
57
| # kwargs.get('items', None), | ||
| # kwargs.get('dtype', LinkedListNode) |
There was a problem hiding this comment.
Why is this commented out? Can we keep the API similar to the ArrayQueue?
There was a problem hiding this comment.
Made LinkedListQueue analogous to ArrayQueue. Now they have similar API.
czgdp1807
reviewed
Mar 6, 2020
|
@manaswinidas Please see if the tests are conceptually correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
FIxes #49 #113
Brief description of what is fixed or changed
Other comments