Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data made optional in public API #249

Merged
merged 5 commits into from
Apr 6, 2020
Merged

data made optional in public API #249

merged 5 commits into from
Apr 6, 2020

Conversation

HarsheetKakar
Copy link
Contributor

References to other Issues or PRs or Relevant literature

solves issue referenced in this comment

Brief description of what is fixed or changed

Other comments

@codecov
Copy link

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #249 into master will not change coverage by %.
The diff coverage is 100.000%.

@@            Coverage Diff            @@
##            master      #249   +/-   ##
=========================================
  Coverage   98.575%   98.575%           
=========================================
  Files           24        24           
  Lines         2106      2106           
=========================================
  Hits          2076      2076           
  Misses          30        30
Impacted Files Coverage Δ
pydatastructs/trees/binary_trees.py 96.951% <100.000%> (ø)
pydatastructs/trees/heaps.py 97.837% <100.000%> (ø)
pydatastructs/trees/m_ary_trees.py 90.625% <100.000%> (ø)

Impacted file tree graph

@HarsheetKakar
Copy link
Contributor Author

merge it so that I can make changes in heapsort as well

@czgdp1807
Copy link
Member

Apply this diff file.

@czgdp1807 czgdp1807 changed the title data made optional in BinaryHeap insert() data made optional in public API Apr 6, 2020
@czgdp1807 czgdp1807 merged commit b2bc6c9 into codezonediitj:master Apr 6, 2020
Vanshika266 pushed a commit to Vanshika266/pydatastructs that referenced this pull request Apr 7, 2020
@HarsheetKakar @Vanshika266
data made optional in public API (codezonediitj#249)
3ffb619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 left review comments

Assignees
No one assigned
Labels
heaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarsheetKakar @czgdp1807 @Harsheet-saxena