Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Binary Heap #46

Merged
merged 10 commits into from
Dec 14, 2019
Merged

Added Binary Heap #46

merged 10 commits into from
Dec 14, 2019

Conversation

czgdp1807
Copy link
Member

References to other Issues or PRs or Relevant literature

#42

Brief description of what is fixed or changed

Other comments

@czgdp1807
Copy link
Member Author

ping @23umesh Apologies for closing your PR by mistake. Your commits are still there and your name will be added to authors file(only if you want). Let me know.

@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #46 into master will increase coverage by 0.107%.
The diff coverage is 99.038%.

@@              Coverage Diff              @@
##            master       #46       +/-   ##
=============================================
+ Coverage   97.895%   98.003%   +0.107%     
=============================================
  Files           15        17        +2     
  Lines          998      1102      +104     
=============================================
+ Hits           977      1080      +103     
- Misses          21        22        +1
Impacted Files Coverage Δ
pydatastructs/trees/tests/test_binary_trees.py 100% <ø> (ø) ⬆️
pydatastructs/trees/tests/test_heaps.py 100% <100%> (ø)
pydatastructs/linear_data_structures/arrays.py 100% <100%> (ø) ⬆️
pydatastructs/trees/__init__.py 100% <100%> (ø) ⬆️
pydatastructs/trees/heaps.py 98.571% <98.571%> (ø)

Impacted file tree graph

@czgdp1807
Copy link
Member Author

@23umesh As you given thumbs up to above comment, I am adding your name to the AUTHORS file. Please let me know your email-id in the comment below.

@czgdp1807
Copy link
Member Author

For now I have added what was available on your Github profile. Make a PR if you want any changes. For now I will merge as soon as the tests pass. Thanks for the contribution.

@czgdp1807 czgdp1807 merged commit 8da8f36 into codezonediitj:master Dec 14, 2019
@czgdp1807 czgdp1807 deleted the binary-heap branch December 15, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants