Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#64 Use comparision by reference for bool type objects #66

Merged
merged 3 commits into from
Dec 26, 2019

Conversation

Saptashrungi
Copy link
Contributor

@Saptashrungi Saptashrungi commented Dec 26, 2019

Fixes #64
Replaced all == 'bool type' with is 'bool type' and similarly replaced != 'bool type' with is not 'bool type'.

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          19       19           
  Lines        1257     1257           
=======================================
  Hits         1234     1234           
  Misses         23       23
Impacted Files Coverage Δ
pydatastructs/trees/space_partitioning_trees.py 97.619% <100%> (ø) ⬆️
...tructs/trees/tests/test_space_partitioning_tree.py 100% <100%> (ø) ⬆️
pydatastructs/linear_data_structures/arrays.py 100% <100%> (ø) ⬆️
pydatastructs/trees/tests/test_binary_trees.py 100% <100%> (ø) ⬆️
...datastructs/miscellaneous_data_structures/stack.py 92.307% <100%> (ø) ⬆️
pydatastructs/trees/binary_trees.py 96.437% <100%> (ø) ⬆️

Impacted file tree graph

@Saptashrungi
Copy link
Contributor Author

Consider the second commit only with the name:

fd9dc53

@czgdp1807
Copy link
Member

LGTM.
Just remove .vs files and push the updates to your addis branch. This PR will be automatically updated. Do not close this PR.

@czgdp1807
Copy link
Member

Consider the second commit only with the name:

We squash and merge commits so that won't be a problem. The overall diff is fine.

@czgdp1807
Copy link
Member

Thanks. Merging.
From next time onward, please do not clear the PULL REQUEST TEMPLATE, instead follow it and fill it. See previously merged PRs for examples.

@czgdp1807 czgdp1807 merged commit 15ab8ba into codezonediitj:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use comparison by reference for bool type objects
2 participants