Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Windows disclaimer around coiled login #21

Open
jrbourbeau opened this issue Apr 5, 2023 · 3 comments
Open

Avoid Windows disclaimer around coiled login #21

jrbourbeau opened this issue Apr 5, 2023 · 3 comments

Comments

@jrbourbeau
Copy link
Member

We're currently using !coiled login --token ... in a notebook cell to authenticate the machine that tutorial attendees are using. This apparently doesn't work well in Windows (I'm not totally sure why) and Windows users are asked to use a power shell instead. Maybe something like subprocess.run could be used instead to make things work smoothly on all OS.

cc @ncclementi for thoughts

@ncclementi
Copy link
Contributor

So when you are not on WSL, and onWIndows using a notebook, If you try to log in you'll get something like this (copying form a feedback email)

Screen Shot 2023-04-05 at 12 21 45 PM

In our coiled docs, we do have a note that says this "For windows users"
Screen Shot 2023-04-05 at 12 22 33 PM

https://docs.coiled.io/user_guide/getting_started.html#set-up-coiled-with-your-cloud-provider

I'd like to avoid using the subprocess.run because it'll make login look more complicated than it is for non-Windows users. I'm not sure what's the best solution here TBH.

maybe @dchudz has a recommendation here, I wonder if there is something that can be done on the platform side, to make login from Windows machines on a notebook easier.

@scharlottej13
Copy link

scharlottej13 commented Apr 5, 2023

Thanks @jrbourbeau + @ncclementi!

fwiw, we chatted w/ a windows user, Ellen, about this. I thought her problem was with coiled login from that screenshot of the error. It seemed that !coiled login -- token <> hadn't had a chance to run, which is why I didn't remove it from the docs at that point. Here are my notes from chatting w/ her.

It sounds like this is happening to other users though and we know it doesn't work? If so happy to remove from the docs.

^ that's tangential to the larger question of "can we remove a windows caveat".

@ncclementi
Copy link
Contributor

It sounds like this is happening to other users though and we know it doesn't work? If so happy to remove from the docs.

Now, I'm not sure if it works or if people are typing the wrong thing in the tutorial.

@crusaderky you have a Windows boot, right? Would you mind trying to do !coiled login -- token <> in a notebook that is NOT launched from WSL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants