Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EqualAddresses to OperationDescription #46

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Add EqualAddresses to OperationDescription #46

merged 4 commits into from
Jun 1, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented May 31, 2020 •
edited
Loading

Motivation

Fixes #44 and Fixes #45

Solution

  • Only run test-cover if COVERALLS_TOKEN is not missing.
  • Add EqualAddresses to OperationDescription

@patrick-ogrady patrick-ogrady linked an issue May 31, 2020 that may be closed by this pull request
Add EqualAddress to OperationDescription #45
Closed
@patrick-ogrady patrick-ogrady changed the title [WIP] Add EqualAddress to OperationDescription Add EqualAddresses to OperationDescription May 31, 2020
@coveralls
Copy link

coveralls commented May 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1643

  • 29 of 31 (93.55%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 66.696%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/match_operations.go 29 31 93.55%
Totals Coverage Status
Change from base Build 1603: 0.3%
Covered Lines: 1498
Relevant Lines: 2246
💛 - Coveralls

@patrick-ogrady patrick-ogrady requested review from annieke, brockmiller, niallo and a team May 31, 2020 00:40
@patrick-ogrady patrick-ogrady merged commit 26ae7bd into master Jun 1, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/equal-address branch June 1, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

@brockmiller brockmiller Awaiting requested review from brockmiller

@niallo niallo Awaiting requested review from niallo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EqualAddress to OperationDescription Support PRs from Forked Repositories
3 participants
@patrick-ogrady @coveralls @annieke