-
Notifications
You must be signed in to change notification settings - Fork 0
/
cyclegraph.cc
658 lines (590 loc) · 17.5 KB
/
cyclegraph.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
#include "cyclegraph.h"
#include "action.h"
#include "common.h"
#include "promise.h"
#include "threads-model.h"
/** Initializes a CycleGraph object. */
CycleGraph::CycleGraph() :
discovered(new HashTable<const CycleNode *, const CycleNode *, uintptr_t, 4, model_malloc, model_calloc, model_free>(16)),
queue(new ModelVector<const CycleNode *>()),
hasCycles(false),
oldCycles(false)
{
}
/** CycleGraph destructor */
CycleGraph::~CycleGraph()
{
delete queue;
delete discovered;
}
/**
* Add a CycleNode to the graph, corresponding to a store ModelAction
* @param act The write action that should be added
* @param node The CycleNode that corresponds to the store
*/
void CycleGraph::putNode(const ModelAction *act, CycleNode *node)
{
actionToNode.put(act, node);
#if SUPPORT_MOD_ORDER_DUMP
nodeList.push_back(node);
#endif
}
/**
* Add a CycleNode to the graph, corresponding to a Promise
* @param promise The Promise that should be added
* @param node The CycleNode that corresponds to the Promise
*/
void CycleGraph::putNode(const Promise *promise, CycleNode *node)
{
promiseToNode.put(promise, node);
#if SUPPORT_MOD_ORDER_DUMP
nodeList.push_back(node);
#endif
}
/**
* @brief Remove the Promise node from the graph
* @param promise The promise to remove from the graph
*/
void CycleGraph::erasePromiseNode(const Promise *promise)
{
promiseToNode.put(promise, NULL);
#if SUPPORT_MOD_ORDER_DUMP
/* Remove the promise node from nodeList */
CycleNode *node = getNode_noCreate(promise);
for (unsigned int i = 0; i < nodeList.size(); )
if (nodeList[i] == node)
nodeList.erase(nodeList.begin() + i);
else
i++;
#endif
}
/** @return The corresponding CycleNode, if exists; otherwise NULL */
CycleNode * CycleGraph::getNode_noCreate(const ModelAction *act) const
{
return actionToNode.get(act);
}
/** @return The corresponding CycleNode, if exists; otherwise NULL */
CycleNode * CycleGraph::getNode_noCreate(const Promise *promise) const
{
return promiseToNode.get(promise);
}
/**
* @brief Returns the CycleNode corresponding to a given ModelAction
*
* Gets (or creates, if none exist) a CycleNode corresponding to a ModelAction
*
* @param action The ModelAction to find a node for
* @return The CycleNode paired with this action
*/
CycleNode * CycleGraph::getNode(const ModelAction *action)
{
CycleNode *node = getNode_noCreate(action);
if (node == NULL) {
node = new CycleNode(action);
putNode(action, node);
}
return node;
}
/**
* @brief Returns a CycleNode corresponding to a promise
*
* Gets (or creates, if none exist) a CycleNode corresponding to a promised
* value.
*
* @param promise The Promise generated by a reader
* @return The CycleNode corresponding to the Promise
*/
CycleNode * CycleGraph::getNode(const Promise *promise)
{
CycleNode *node = getNode_noCreate(promise);
if (node == NULL) {
node = new CycleNode(promise);
putNode(promise, node);
}
return node;
}
/**
* Resolve/satisfy a Promise with a particular store ModelAction, taking care
* of the CycleGraph cleanups, including merging any necessary CycleNodes.
*
* @param promise The Promise to resolve
* @param writer The store that will resolve this Promise
* @return false if the resolution results in a cycle (or fails in some other
* way); true otherwise
*/
bool CycleGraph::resolvePromise(const Promise *promise, ModelAction *writer)
{
CycleNode *promise_node = promiseToNode.get(promise);
CycleNode *w_node = actionToNode.get(writer);
ASSERT(promise_node);
if (w_node)
return mergeNodes(w_node, promise_node);
/* No existing write-node; just convert the promise-node */
promise_node->resolvePromise(writer);
erasePromiseNode(promise_node->getPromise());
putNode(writer, promise_node);
return true;
}
/**
* @brief Merge two CycleNodes that represent the same write
*
* Note that this operation cannot be rolled back.
*
* @param w_node The write ModelAction node with which to merge
* @param p_node The Promise node to merge. Will be destroyed after this
* function.
*
* @return false if the merge cannot succeed; true otherwise
*/
bool CycleGraph::mergeNodes(CycleNode *w_node, CycleNode *p_node)
{
ASSERT(!w_node->is_promise());
ASSERT(p_node->is_promise());
const Promise *promise = p_node->getPromise();
if (!promise->is_compatible(w_node->getAction()) ||
!promise->same_value(w_node->getAction()))
return false;
/* Transfer the RMW */
CycleNode *promise_rmw = p_node->getRMW();
if (promise_rmw && promise_rmw != w_node->getRMW() && w_node->setRMW(promise_rmw))
return false;
/* Transfer back edges to w_node */
while (p_node->getNumBackEdges() > 0) {
CycleNode *back = p_node->removeBackEdge();
if (back == w_node)
continue;
addNodeEdge(back, w_node);
if (hasCycles)
return false;
}
/* Transfer forward edges to w_node */
while (p_node->getNumEdges() > 0) {
CycleNode *forward = p_node->removeEdge();
if (forward == w_node)
continue;
addNodeEdge(w_node, forward);
if (hasCycles)
return false;
}
erasePromiseNode(promise);
/* Not deleting p_node, to maintain consistency if mergeNodes() fails */
return !hasCycles;
}
/**
* Adds an edge between two CycleNodes.
* @param fromnode The edge comes from this CycleNode
* @param tonode The edge points to this CycleNode
* @return True, if new edge(s) are added; otherwise false
*/
bool CycleGraph::addNodeEdge(CycleNode *fromnode, CycleNode *tonode)
{
if (fromnode->addEdge(tonode)) {
rollbackvector.push_back(fromnode);
if (!hasCycles)
hasCycles = checkReachable(tonode, fromnode);
} else
return false; /* No new edge */
/*
* If the fromnode has a rmwnode that is not the tonode, we should
* follow its RMW chain to add an edge at the end, unless we encounter
* tonode along the way
*/
CycleNode *rmwnode = fromnode->getRMW();
if (rmwnode) {
while (rmwnode != tonode && rmwnode->getRMW())
rmwnode = rmwnode->getRMW();
if (rmwnode != tonode) {
if (rmwnode->addEdge(tonode)) {
if (!hasCycles)
hasCycles = checkReachable(tonode, rmwnode);
rollbackvector.push_back(rmwnode);
}
}
}
return true;
}
/**
* @brief Add an edge between a write and the RMW which reads from it
*
* Handles special case of a RMW action, where the ModelAction rmw reads from
* the ModelAction/Promise from. The key differences are:
* -# No write can occur in between the @a rmw and @a from actions.
* -# Only one RMW action can read from a given write.
*
* @param from The edge comes from this ModelAction/Promise
* @param rmw The edge points to this ModelAction; this action must read from
* the ModelAction/Promise from
*/
template <typename T>
void CycleGraph::addRMWEdge(const T *from, const ModelAction *rmw)
{
ASSERT(from);
ASSERT(rmw);
CycleNode *fromnode = getNode(from);
CycleNode *rmwnode = getNode(rmw);
/* We assume that this RMW has no RMW reading from it yet */
ASSERT(!rmwnode->getRMW());
/* Two RMW actions cannot read from the same write. */
if (fromnode->setRMW(rmwnode))
hasCycles = true;
else
rmwrollbackvector.push_back(fromnode);
/* Transfer all outgoing edges from the from node to the rmw node */
/* This process should not add a cycle because either:
* (1) The rmw should not have any incoming edges yet if it is the
* new node or
* (2) the fromnode is the new node and therefore it should not
* have any outgoing edges.
*/
for (unsigned int i = 0; i < fromnode->getNumEdges(); i++) {
CycleNode *tonode = fromnode->getEdge(i);
if (tonode != rmwnode) {
if (rmwnode->addEdge(tonode))
rollbackvector.push_back(rmwnode);
}
}
addNodeEdge(fromnode, rmwnode);
}
/* Instantiate two forms of CycleGraph::addRMWEdge */
template void CycleGraph::addRMWEdge(const ModelAction *from, const ModelAction *rmw);
template void CycleGraph::addRMWEdge(const Promise *from, const ModelAction *rmw);
/**
* @brief Adds an edge between objects
*
* This function will add an edge between any two objects which can be
* associated with a CycleNode. That is, if they have a CycleGraph::getNode
* implementation.
*
* The object to is ordered after the object from.
*
* @param to The edge points to this object, of type T
* @param from The edge comes from this object, of type U
* @return True, if new edge(s) are added; otherwise false
*/
template <typename T, typename U>
bool CycleGraph::addEdge(const T *from, const U *to)
{
ASSERT(from);
ASSERT(to);
CycleNode *fromnode = getNode(from);
CycleNode *tonode = getNode(to);
return addNodeEdge(fromnode, tonode);
}
/* Instantiate four forms of CycleGraph::addEdge */
template bool CycleGraph::addEdge(const ModelAction *from, const ModelAction *to);
template bool CycleGraph::addEdge(const ModelAction *from, const Promise *to);
template bool CycleGraph::addEdge(const Promise *from, const ModelAction *to);
template bool CycleGraph::addEdge(const Promise *from, const Promise *to);
#if SUPPORT_MOD_ORDER_DUMP
static void print_node(FILE *file, const CycleNode *node, int label)
{
if (node->is_promise()) {
const Promise *promise = node->getPromise();
int idx = promise->get_index();
fprintf(file, "P%u", idx);
if (label) {
int first = 1;
fprintf(file, " [label=\"P%d, T", idx);
for (unsigned int i = 0 ; i < promise->max_available_thread_idx(); i++)
if (promise->thread_is_available(int_to_id(i))) {
fprintf(file, "%s%u", first ? "": ",", i);
first = 0;
}
fprintf(file, "\"]");
}
} else {
const ModelAction *act = node->getAction();
modelclock_t idx = act->get_seq_number();
fprintf(file, "N%u", idx);
if (label)
fprintf(file, " [label=\"N%u, T%u\"]", idx, act->get_tid());
}
}
static void print_edge(FILE *file, const CycleNode *from, const CycleNode *to, const char *prop)
{
print_node(file, from, 0);
fprintf(file, " -> ");
print_node(file, to, 0);
if (prop && strlen(prop))
fprintf(file, " [%s]", prop);
fprintf(file, ";\n");
}
void CycleGraph::dot_print_node(FILE *file, const ModelAction *act)
{
print_node(file, getNode(act), 1);
}
template <typename T, typename U>
void CycleGraph::dot_print_edge(FILE *file, const T *from, const U *to, const char *prop)
{
CycleNode *fromnode = getNode(from);
CycleNode *tonode = getNode(to);
print_edge(file, fromnode, tonode, prop);
}
/* Instantiate two forms of CycleGraph::dot_print_edge */
template void CycleGraph::dot_print_edge(FILE *file, const Promise *from, const ModelAction *to, const char *prop);
template void CycleGraph::dot_print_edge(FILE *file, const ModelAction *from, const ModelAction *to, const char *prop);
void CycleGraph::dumpNodes(FILE *file) const
{
for (unsigned int i = 0; i < nodeList.size(); i++) {
CycleNode *n = nodeList[i];
print_node(file, n, 1);
fprintf(file, ";\n");
if (n->getRMW())
print_edge(file, n, n->getRMW(), "style=dotted");
for (unsigned int j = 0; j < n->getNumEdges(); j++)
print_edge(file, n, n->getEdge(j), NULL);
}
}
void CycleGraph::dumpGraphToFile(const char *filename) const
{
char buffer[200];
sprintf(buffer, "%s.dot", filename);
FILE *file = fopen(buffer, "w");
fprintf(file, "digraph %s {\n", filename);
dumpNodes(file);
fprintf(file, "}\n");
fclose(file);
}
#endif
/**
* Checks whether one CycleNode can reach another.
* @param from The CycleNode from which to begin exploration
* @param to The CycleNode to reach
* @return True, @a from can reach @a to; otherwise, false
*/
bool CycleGraph::checkReachable(const CycleNode *from, const CycleNode *to) const
{
discovered->reset();
queue->clear();
queue->push_back(from);
discovered->put(from, from);
while (!queue->empty()) {
const CycleNode *node = queue->back();
queue->pop_back();
if (node == to)
return true;
for (unsigned int i = 0; i < node->getNumEdges(); i++) {
CycleNode *next = node->getEdge(i);
if (!discovered->contains(next)) {
discovered->put(next, next);
queue->push_back(next);
}
}
}
return false;
}
/**
* Checks whether one ModelAction/Promise can reach another ModelAction/Promise
* @param from The ModelAction or Promise from which to begin exploration
* @param to The ModelAction or Promise to reach
* @return True, @a from can reach @a to; otherwise, false
*/
template <typename T, typename U>
bool CycleGraph::checkReachable(const T *from, const U *to) const
{
CycleNode *fromnode = getNode_noCreate(from);
CycleNode *tonode = getNode_noCreate(to);
if (!fromnode || !tonode)
return false;
return checkReachable(fromnode, tonode);
}
/* Instantiate four forms of CycleGraph::checkReachable */
template bool CycleGraph::checkReachable(const ModelAction *from,
const ModelAction *to) const;
template bool CycleGraph::checkReachable(const ModelAction *from,
const Promise *to) const;
template bool CycleGraph::checkReachable(const Promise *from,
const ModelAction *to) const;
template bool CycleGraph::checkReachable(const Promise *from,
const Promise *to) const;
/** @return True, if the promise has failed; false otherwise */
bool CycleGraph::checkPromise(const ModelAction *fromact, Promise *promise) const
{
discovered->reset();
queue->clear();
CycleNode *from = actionToNode.get(fromact);
queue->push_back(from);
discovered->put(from, from);
while (!queue->empty()) {
const CycleNode *node = queue->back();
queue->pop_back();
if (node->getPromise() == promise)
return true;
if (!node->is_promise())
promise->eliminate_thread(node->getAction()->get_tid());
for (unsigned int i = 0; i < node->getNumEdges(); i++) {
CycleNode *next = node->getEdge(i);
if (!discovered->contains(next)) {
discovered->put(next, next);
queue->push_back(next);
}
}
}
return false;
}
/** @brief Begin a new sequence of graph additions which can be rolled back */
void CycleGraph::startChanges()
{
ASSERT(rollbackvector.empty());
ASSERT(rmwrollbackvector.empty());
ASSERT(oldCycles == hasCycles);
}
/** Commit changes to the cyclegraph. */
void CycleGraph::commitChanges()
{
rollbackvector.clear();
rmwrollbackvector.clear();
oldCycles = hasCycles;
}
/** Rollback changes to the previous commit. */
void CycleGraph::rollbackChanges()
{
for (unsigned int i = 0; i < rollbackvector.size(); i++)
rollbackvector[i]->removeEdge();
for (unsigned int i = 0; i < rmwrollbackvector.size(); i++)
rmwrollbackvector[i]->clearRMW();
hasCycles = oldCycles;
rollbackvector.clear();
rmwrollbackvector.clear();
}
/** @returns whether a CycleGraph contains cycles. */
bool CycleGraph::checkForCycles() const
{
return hasCycles;
}
/**
* @brief Constructor for a CycleNode
* @param act The ModelAction for this node
*/
CycleNode::CycleNode(const ModelAction *act) :
action(act),
promise(NULL),
hasRMW(NULL)
{
}
/**
* @brief Constructor for a Promise CycleNode
* @param promise The Promise which was generated
*/
CycleNode::CycleNode(const Promise *promise) :
action(NULL),
promise(promise),
hasRMW(NULL)
{
}
/**
* @param i The index of the edge to return
* @returns The CycleNode edge indexed by i
*/
CycleNode * CycleNode::getEdge(unsigned int i) const
{
return edges[i];
}
/** @returns The number of edges leaving this CycleNode */
unsigned int CycleNode::getNumEdges() const
{
return edges.size();
}
/**
* @param i The index of the back edge to return
* @returns The CycleNode back-edge indexed by i
*/
CycleNode * CycleNode::getBackEdge(unsigned int i) const
{
return back_edges[i];
}
/** @returns The number of edges entering this CycleNode */
unsigned int CycleNode::getNumBackEdges() const
{
return back_edges.size();
}
/**
* @brief Remove an element from a vector
* @param v The vector
* @param n The element to remove
* @return True if the element was found; false otherwise
*/
template <typename T>
static bool vector_remove_node(SnapVector<T>& v, const T n)
{
for (unsigned int i = 0; i < v.size(); i++) {
if (v[i] == n) {
v.erase(v.begin() + i);
return true;
}
}
return false;
}
/**
* @brief Remove a (forward) edge from this CycleNode
* @return The CycleNode which was popped, if one exists; otherwise NULL
*/
CycleNode * CycleNode::removeEdge()
{
if (edges.empty())
return NULL;
CycleNode *ret = edges.back();
edges.pop_back();
vector_remove_node(ret->back_edges, this);
return ret;
}
/**
* @brief Remove a (back) edge from this CycleNode
* @return The CycleNode which was popped, if one exists; otherwise NULL
*/
CycleNode * CycleNode::removeBackEdge()
{
if (back_edges.empty())
return NULL;
CycleNode *ret = back_edges.back();
back_edges.pop_back();
vector_remove_node(ret->edges, this);
return ret;
}
/**
* Adds an edge from this CycleNode to another CycleNode.
* @param node The node to which we add a directed edge
* @return True if this edge is a new edge; false otherwise
*/
bool CycleNode::addEdge(CycleNode *node)
{
for (unsigned int i = 0; i < edges.size(); i++)
if (edges[i] == node)
return false;
edges.push_back(node);
node->back_edges.push_back(this);
return true;
}
/** @returns the RMW CycleNode that reads from the current CycleNode */
CycleNode * CycleNode::getRMW() const
{
return hasRMW;
}
/**
* Set a RMW action node that reads from the current CycleNode.
* @param node The RMW that reads from the current node
* @return True, if this node already was read by another RMW; false otherwise
* @see CycleGraph::addRMWEdge
*/
bool CycleNode::setRMW(CycleNode *node)
{
if (hasRMW != NULL)
return true;
hasRMW = node;
return false;
}
/**
* Convert a Promise CycleNode into a concrete-valued CycleNode. Should only be
* used when there's no existing ModelAction CycleNode for this write.
*
* @param writer The ModelAction which wrote the future value represented by
* this CycleNode
*/
void CycleNode::resolvePromise(const ModelAction *writer)
{
ASSERT(is_promise());
ASSERT(promise->is_compatible(writer));
action = writer;
promise = NULL;
ASSERT(!is_promise());
}